-
Notifications
You must be signed in to change notification settings - Fork 232
8343875: Minor improvements of jpackage test library #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8343875
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
I read nothing about omitted DirectoryContentVerifierTest .java . |
|
Hi @MBaesken |
|
|
|
/integrate |
|
Going to push as commit 45bbc37.
Your commit was automatically rebased without conflicts. |
Backport of the change in 21.
Resolved one import in test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java.
Unfortunately I had to omit patching test/jdk/tools/jpackage/share/AddLShortcutTest.java
which is not in 17.
I had to keep the import of java.awt.Desktop in PackageTest.java to make it compile.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4071/head:pull/4071$ git checkout pull/4071Update a local copy of the PR:
$ git checkout pull/4071$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4071/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4071View PR using the GUI difftool:
$ git pr show -t 4071Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4071.diff
Using Webrev
Link to Webrev Comment